feat: Use Store API pagination for serial logs table#5684
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the publisher “Serial logs” UI and API proxy to use cursor-based pagination (Store API pagination) rather than client-side table pagination.
Changes:
- Update the serial logs Flask endpoint to forward pagination/filter params as a single params object to the Store API gateway.
- Replace client-side table pagination with cursor-driven pagination controls in the Serial Logs page and table.
- Adjust the
useSerialLogshook API (renamenextPage→page) and update its tests; bumpcanonicalwebteam.store-apidependency.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| webapp/endpoints/models.py | Changes serial log endpoint to forward pagination/filter params via a dict. |
| static/js/publisher/pages/SerialLog/SerialLogTable.tsx | Replaces TablePagination usage with cursor-based TablePaginationControls and adds required pagination props. |
| static/js/publisher/pages/SerialLog/SerialLog.tsx | Adds cursor state/history and wires pagination controls to useSerialLogs. |
| static/js/publisher/pages/Remodel/Remodel.tsx | Adjusts search param updates for page size to preserve existing params. |
| static/js/publisher/layouts/ModelDetailsPageLayout/ModelNav.tsx | Conditionally shows “Serial log” tab based on useSerialLogs success. |
| static/js/publisher/hooks/useSerialLogs.ts | Renames cursor param to page, refines query key, and sets cursor query param. |
| static/js/publisher/hooks/tests/useSerialLogs.test.tsx | Updates tests to use page instead of nextPage. |
| requirements.txt | Bumps canonicalwebteam.store-api from 7.8.2 to 7.8.3. |
Contributor
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
steverydz
force-pushed
the
WD-35798-update-pagination-for-serial-logs-table
branch
from
06bfe55 to
49c46d9
Compare
edisile
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
next-cursorparameter from the Store APIHow to QA
start-timeandend-timeto the URL if the login redirect loses those parameters (these are required because the only logs we have are now past the 30 day cutoff - filters will come in a subsequent PR)page-sizequery param is updated in the URL when using the page size selectorTesting
Security
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-35798
Screenshots
n/a
UX Approval